[PATCH 2/3] coresight: Add coresight slave register driver to support data filter function in sysfs mode

[Greg Kroah-Hartman]

On Wed, Jun 19, 2024 at 09:55:25AM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/hwtracing/coresight/coresight-csr.c
> > @@ -0,0 +1,315 @@
> …
> > +static int __csr_set_etr_traceid(struct coresight_device *csdev,
> > +			uint32_t atid_offset, uint32_t traceid,
> > +			bool enable)
> > +{
> …
> > +	spin_lock_irqsave(&drvdata->spin_lock, flags);
> > +	CS_UNLOCK(drvdata->base);
> …
> > +	CS_LOCK(drvdata->base);
> > +	spin_unlock_irqrestore(&drvdata->spin_lock, flags);
> > +	return 0;
> > +}
> …
> 
> Would you become interested to apply a statement like “guard(spinlock_irqsave)(&drvdata->spin_lock);”?
> https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/spinlock.h#L574


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot