[PATCH v3 16/18] media: venus: Refactor hfi_sys_get_property_pkt
Vikash Garodia
quic_vgarodia at quicinc.com
Tue Jun 18 05:26:12 PDT 2024
On 5/28/2024 2:39 AM, Ricardo Ribalda wrote:
> Replace a single length element array with an element.
>
> This fixes the following cocci warning:
> drivers/media/platform/qcom/venus/hfi_cmds.h:77:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Ricardo Ribalda <ribalda at chromium.org>
> ---
> drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +-
> drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c
> index 75f4a3d3e748..0a4de8ca1df5 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.c
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c
> @@ -156,7 +156,7 @@ void pkt_sys_image_version(struct hfi_sys_get_property_pkt *pkt)
> pkt->hdr.size = sizeof(*pkt);
> pkt->hdr.pkt_type = HFI_CMD_SYS_GET_PROPERTY;
> pkt->num_properties = 1;
> - pkt->data[0] = HFI_PROPERTY_SYS_IMAGE_VERSION;
> + pkt->data = HFI_PROPERTY_SYS_IMAGE_VERSION;
> }
>
> int pkt_session_init(struct hfi_session_init_pkt *pkt, void *cookie,
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h
> index 2c56ae303989..f91bc9087643 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.h
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h
> @@ -74,7 +74,7 @@ struct hfi_sys_set_property_pkt {
> struct hfi_sys_get_property_pkt {
> struct hfi_pkt_hdr hdr;
> u32 num_properties;
> - u32 data[1];
> + u32 data;
> };
>
> struct hfi_sys_ping_pkt {
>
>
Acked-by: Vikash Garodia <quic_vgarodia at quicinc.com>
More information about the linux-arm-kernel
mailing list