[PATCH] wifi: mt76: un-embedd netdev from mt76_dev

Kalle Valo kvalo at kernel.org
Mon Jun 17 02:03:49 PDT 2024


Breno Leitao <leitao at debian.org> writes:

> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_devices from struct mt76_dev by converting them
> into pointers, and allocating them dynamically. Use the leverage
> alloc_netdev_dummy() to allocate the net_device object at
> mt76_dma_init().
>
> The free of the device occurs at mt76_dma_cleanup().
>
> Link: https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ [1]
> Signed-off-by: Breno Leitao <leitao at debian.org>
> ---
>
> PS: Due to the lack of hardware, this patch was not tested on a real
> hardware, unfortunately.
>
> PS2: this is the last driver that is still using embedded netdevices.

Is this patch a dependency to other patches? I'm asking because it will
be _slow_ to get this patch to net-next via wireless trees. If there's
urgency then it's much better to take it directly to net-next (of course
with acks from Felix and Lorenzo).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the linux-arm-kernel mailing list