[PATCH v2 01/10] iommu/arm-smmu-v3: Do not zero the strtab twice

Jason Gunthorpe jgg at nvidia.com
Wed Jun 12 04:46:58 PDT 2024


On Tue, Jun 11, 2024 at 04:52:57PM -0700, Daniel Mentz wrote:

> I thought there was a guideline around not printing error messages on
> certain allocation failures because there'll be a generic OOM message
> that'll get printed. 

Oops, right, C&P mistake. I removed it.

> Also, this driver never prints an error message
> when devm_kcalloc or devm_kzalloc fails, only on dmam_alloc_coherent
> failures.

dma_alloc_coherent generates the same dump as kzalloc on ENOMEM, I
guessed the intention was to add extra logging on the high order
allocations, but this allocation is larger than the dma one and
doesn't get a print so <shrug>

I was tempted to remove those prints too..

Thanks,
Jason



More information about the linux-arm-kernel mailing list