[EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree bindings

[Aisheng Dong]

Hi Krzysztof

> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 2024年6月7日 15:08
> 
> On 07/06/2024 06:58, Vabhav Sharma wrote:
> >>
> >> Missing SoC compatibles.
> > Ok, I will use fsl,imx8dxl-sc-secvio
> >>
> >> So no, that's just abuse of DT to instantiate driver.
> >>
> >> NAK. Drop the binding.
> > I will detail the dt binding to describe the real hardware
> 
> Still looks like way just to instantiate driver. Why it cannot be part of existing
> firmware SCU node?
> 

Technically yes. But SCU case is a little bit complicated as there're many
functions and all of them are already added as sub nodes in SCU node
for consistency and handling platform difference.

I guess some of them, e.g. rtc, could be part of SCU node (reuse) while
some couldn't. e.g. pinctrl
Do you want us to only make secvio reuse existing SCU node? 
This might look a bit strange to the existing sub nodes.

BTW, even we can reuse SCU node for secvio function, we still need update
binding doc to add extra property 'nvmem' for secvio.
Please share your suggestions considering above information.

e.g.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
    firmware {
        system-controller {
            compatible = "fsl,imx-scu";
	    ....

            rtc {
                compatible = "fsl,imx8qxp-sc-rtc";
            };

            keys {
                compatible = "fsl,imx8qxp-sc-key", "fsl,imx-sc-key";
                linux,keycodes = <KEY_POWER>;
            };

            watchdog {
                compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
                timeout-sec = <60>;
            };

            thermal-sensor {
                compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal";
                #thermal-sensor-cells = <1>;
            };
	.....
    };

Regards
Aisheng

> Best regards,
> Krzysztof