[PATCH v3 1/2] hwrng: stm32 - use pm_runtime_resume_and_get()

[Herbert Xu]

On Fri, May 31, 2024 at 10:53:22AM +0200, Marek Vasut wrote:
> include/linux/pm_runtime.h pm_runtime_get_sync() description suggests to
> ... consider using pm_runtime_resume_and_get() instead of it, especially
> if its return value is checked by the caller, as this is likely to result
> in cleaner code.
> 
> This is indeed better, switch to pm_runtime_resume_and_get() which
> correctly suspends the device again in case of failure. Also add error
> checking into the RNG driver in case pm_runtime_resume_and_get() does
> fail, which is currently not done, and it does detect sporadic -EACCES
> error return after resume, which would otherwise lead to a hang due to
> register access on un-resumed hardware. Now the read simply errors out
> and the system does not hang.
> 
> Acked-by: Gatien Chevallier <gatien.chevallier at foss.st.com>
> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: "Uwe Kleine-König" <u.kleine-koenig at pengutronix.de>
> Cc: Alexandre Torgue <alexandre.torgue at foss.st.com>
> Cc: Gatien Chevallier <gatien.chevallier at foss.st.com>
> Cc: Herbert Xu <herbert at gondor.apana.org.au>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
> Cc: Olivia Mackall <olivia at selenic.com>
> Cc: Rob Herring <robh at kernel.org>
> Cc: Yang Yingliang <yangyingliang at huawei.com>
> Cc: kernel at dh-electronics.com
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-crypto at vger.kernel.org
> Cc: linux-stm32 at st-md-mailman.stormreply.com
> ---
> V2: Add AB from Gatien
> V3: No change
> ---
>  drivers/char/hw_random/stm32-rng.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt