[PATCH 2/3] pinctrl: rockchip: use dedicated pinctrl type for RK3328
Heiko Stübner
heiko at sntech.de
Thu Jun 6 03:11:15 PDT 2024
Am Donnerstag, 6. Juni 2024, 11:43:56 CEST schrieb Heiko Stübner:
> Am Donnerstag, 6. Juni 2024, 08:04:34 CEST schrieb Huang-Huang Bao:
> > rk3328_pin_ctrl uses type of RK3288 which has a hack in
> > rockchip_pinctrl_suspend and rockchip_pinctrl_resume to restore GPIO6-C6
> > at assume, the hack is not applicable to RK3328 as GPIO6 is not even
> > exist in it. So use a dedicated pinctrl type to skip this hack.
> >
> > Signed-off-by: Huang-Huang Bao <i at eh5.me>
>
> Reviewed-by: Heiko Stuebner <heiko at sntech.de>
I think this actually also warrants a Fixes-tag, because as you said, the
suspend handling for the rk3288 will change GRF registers it should not
touch on the rk3328.
Fixes: 3818e4a7678e ("pinctrl: rockchip: Add rk3328 pinctrl support")
More information about the linux-arm-kernel
mailing list