[PATCH 02/11] staging: vchiq_arm: Drop obsolete comment

[Dan Carpenter]

On Wed, Jun 05, 2024 at 12:02:40PM +0200, Stefan Wahren wrote:
> Hi Laurent,
> 
> Am 05.06.24 um 08:52 schrieb Laurent Pinchart:
> > Hi Stefan,
> > 
> > Thank you for the patch.
> > 
> > On Tue, Jun 04, 2024 at 07:28:55PM +0200, Stefan Wahren wrote:
> > > The BUG_ON has been replaced with WARN_ON. So we can drop the
> > > comment.
> > Note https://lwn.net/Articles/969923/ :-)
> > 
> > This being said, I think the comment can be dropped, regardless of
> > whether or not we drop the WARN_ON() later.
> thanks i wasn't aware of that article. I think, we can address this in a
> separate series and try to replace WARN_ON() with dev_warn() in cases it
> makes sense.

I looked at the callers and it does look like a user could trigger these
via the VCHIQ_IOC_RELEASE_SERVICE ioctl so it should be dev_warn(), yes.
It's not necessarily in use at the time.


regards,
dan carpenter