[PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator

Andy Shevchenko andy.shevchenko at gmail.com
Tue Jun 4 00:33:18 PDT 2024


On Tue, Jun 4, 2024 at 10:28 AM Florian Fainelli
<florian.fainelli at broadcom.com> wrote:
> On 6/3/2024 8:19 PM, Stefan Wahren wrote:

...

> LGTM but sometimes I really wonder to what degree should we invent a
> helper function...

The rationale for the messaging is unification, that's why helpers
like dev_err_probe() (for known non-deferred error codes), str_*()
choices, and %pt (to have time and date be printed) are good to have.
In general I agree that we should't become fanatics of hiding
everything behind the macros and helpers.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list