[PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC

[Lorenzo Bianconi]

> > +static void airoha_remove(struct platform_device *pdev)
> > +{
> > +	struct airoha_eth *eth = platform_get_drvdata(pdev);
> > +	int i;
> > +
> > +	debugfs_remove(eth->debugfs_dir);
> > +
> > +	airoha_qdma_for_each_q_rx(eth, i) {
> > +		struct airoha_queue *q = &eth->q_rx[i];
> > +
> > +		netif_napi_del(&q->napi);
> > +		airoha_qdma_clenaup_rx_queue(q);
> > +		page_pool_destroy(q->page_pool);
> > +	}
> > +
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++)
> > +		netif_napi_del(&eth->q_tx_irq[i].napi);
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++)
> > +		airoha_qdma_clenaup_tx_queue(&eth->q_tx[i]);
> > +}
> 
> You don't appear to unregister the netdev. remove() should basically
> be the reverse of probe().
> 
>     Andrew

ack, I will fix it in v2.

Regards,
Lorenzo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240602/bf9d942d/attachment.sig>