[PATCH] rust: error: allow `useless_conversion` for 32-bit builds
Miguel Ojeda
miguel.ojeda.sandonis at gmail.com
Tue Jul 30 13:22:41 PDT 2024
On Tue, Jul 30, 2024 at 7:55 PM Alice Ryhl <aliceryhl at google.com> wrote:
>
> The formatting here is a bit weird. Perhaps we should swap the cfg and
> the comment?
Yeah, I don't like it either -- I reflexively did it because in the
safety series I am sending, there was a case where it would not notice
the `// SAFETY` comment if an attribute was placed afterwards.
But for blocks like this works fine, so it is not needed here, so we
can change it, even we may need to be inconsistent in a few places
about this, at least until it is fixed (assuming it is indeed a false
positive).
I created an issue in Clippy about it:
https://github.com/rust-lang/rust-clippy/issues/13189.
Thanks!
Cheers,
Miguel
More information about the linux-arm-kernel
mailing list