[PATCH 06/13] irqchip/armada-370-xp: Put static variables into driver private structure

Thomas Gleixner tglx at linutronix.de
Sun Jul 28 14:44:43 PDT 2024


On Mon, Jul 15 2024 at 12:51, Marek Behún wrote:
> +struct mpic {
> +	/* Register regions */
> +	void __iomem *base;
> +	void __iomem *per_cpu;
> +
> +	/* If MPIC is not top-level interrupt controller */
> +	int parent_irq;
> +
> +	/* Main IRQ domain */
> +	struct irq_domain *domain;
> +
> +#ifdef CONFIG_SMP
> +	/* IPI interrupts */
> +	struct irq_domain *ipi_domain;
> +#endif
> +
>  #ifdef CONFIG_PCI_MSI
> -static struct irq_domain *mpic_msi_domain;
> -static struct irq_domain *mpic_msi_inner_domain;
> -static DECLARE_BITMAP(msi_used, PCI_MSI_FULL_DOORBELL_NR);
> -static DEFINE_MUTEX(msi_used_lock);
> -static phys_addr_t msi_doorbell_addr;
> +	/* MSI interrupts */
> +	struct irq_domain *msi_domain;
> +	struct irq_domain *msi_inner_domain;
> +	DECLARE_BITMAP(msi_used, PCI_MSI_FULL_DOORBELL_NR);
> +	struct mutex msi_lock;
> +	phys_addr_t msi_doorbell_addr;
>  #endif
>  
> +	/* suspend & resume */
> +	u32 doorbell_mask;
> +};

Please see:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-declarations-and-initializers

Thanks,

        tglx



More information about the linux-arm-kernel mailing list