[PATCH 03/13] irqchip/armada-370-xp: Rename struct irq_domain variables for consistency
Thomas Gleixner
tglx at linutronix.de
Sun Jul 28 14:41:25 PDT 2024
On Mon, Jul 15 2024 at 12:51, Marek Behún wrote:
> Rename struct irq_domain variables passed as arguments into callbacks to
> "h", for consistency. The "d" name is reserved for irq_data, while
> "domain" is unnecessarily long.
'domain' is way more descriptive than the pulled out of thin air 'h'.
I'm not convinced about the value of this change.
> for (unsigned int i = 0; i < nr_irqs; i++)
> - irq_domain_set_info(domain, virq + i, hwirq + i,
> + irq_domain_set_info(h, virq + i, hwirq + i,
> &mpic_msi_bottom_irq_chip,
> - domain->host_data, handle_simple_irq,
> + h->host_data, handle_simple_irq,
> NULL, NULL);
Reducing the number of line breaks by utilizing the 100 character limit
would be more valuable.
Thanks,
tglx
More information about the linux-arm-kernel
mailing list