[EXT] Re: [PATCH] usb: cdns3: imx: simplify system pm using _force_suspend/_resume

Shenwei Wang shenwei.wang at nxp.com
Fri Jul 26 07:35:17 PDT 2024



> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Sent: Friday, July 26, 2024 1:56 AM
> To: Shenwei Wang <shenwei.wang at nxp.com>
> Cc: Peter Chen <peter.chen at kernel.org>; Pawel Laszczak
> <pawell at cadence.com>; Shawn Guo <shawnguo at kernel.org>; Sascha Hauer
> >
> > Fixes: db3c4e366287 ("usb: cdns3: imx: Rework system PM to avoid
> > duplicated operations")
> > Reviewed-by: Frank Li <frank.li at nxp.com>
> > Signed-off-by: Shenwei Wang <shenwei.wang at nxp.com>
> > ---
> >  drivers/usb/cdns3/cdns3-imx.c | 18 +++++++-----------
> >  1 file changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/usb/cdns3/cdns3-imx.c
> > b/drivers/usb/cdns3/cdns3-imx.c index 281de47e2a3b..9051cbe9d68b
> > 100644
> > --- a/drivers/usb/cdns3/cdns3-imx.c
> > +++ b/drivers/usb/cdns3/cdns3-imx.c
> > @@ -360,7 +360,6 @@ static int cdns_imx_suspend(struct device *dev)
> >       return 0;
> >  }
> >
> > -
> >  /* Indicate if the controller was power lost before */  static inline
> > bool cdns_imx_is_power_lost(struct cdns_imx *data)  {
> 
> Unneeded change here?
> 

That is an extraneous blank line was introduced in last commit and has been removed as part of this correction. 
If you prefer to maintain the original formatting with the extra blank line, please let me know, and I can revert this change.

Thanks,
Shenwei






More information about the linux-arm-kernel mailing list