[PATCH] net: stmmac: fix the mistake of the device tree property string of reset gpio in stmmac_mdio_reset

Paolo Abeni pabeni at redhat.com
Tue Jul 23 03:47:57 PDT 2024


On 7/20/24 06:00, Zhouyi Zhou wrote:
> From: "zhili.liu" <zhili.liu at ucas.com.cn>
> 
> According to Documentation/devicetree/bindings/net/snps,dwmac.yaml,
> the device tree property of PHY Reset GPIO should be "snps,reset-gpio".
> 
> Use string "snps,reset-gpio" instead of "snps,reset" in stmmac_mdio_reset
> when invoking devm_gpiod_get_optional.
> 
> Fixes: 7c86f20d15b7 ("net: stmmac: use GPIO descriptors in stmmac_mdio_reset")
> 
> Signed-off-by: Zhouyi Zhou <zhouzhouyi at gmail.com>
> Signed-off-by: wangzhiqiang <zhiqiangwang at ucas.com.cn>
> Signed-off-by: zhili.liu <zhili.liu at ucas.com.cn>

Apart from the more relevant concern raised from Andrew, please note 
that you should avoid empty lines in the tag area, between the 'fixes' 
tag and the SoB tag.

Thanks,

Paolo




More information about the linux-arm-kernel mailing list