[PATCH] kselftest: missing arg in ptrace.c

Dev Jain dev.jain at arm.com
Mon Jul 15 21:19:12 PDT 2024


On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga at uci.edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
>
>   tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
>   		/* Zero is not currently architecturally valid */
>   		ksft_test_result(arch, "%s_arch_set\n", type_name);
>   	} else {
> -		ksft_test_result_skip("%s_arch_set\n");
> +		ksft_test_result_skip("%s_arch_set\n", type_name);
>   	}
>   }

Okay, I almost forgot that I had a patch fixing this as part of another series:
https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
If that is OK, Will, can you please pull that? Or should I send that as a
separate patch?




More information about the linux-arm-kernel mailing list