[PATCH v3 1/1] watchdog: imx7ulp_wdt: move post_rcs_wait into struct imx_wdt_hw_feature

Guenter Roeck linux at roeck-us.net
Mon Jul 15 14:44:16 PDT 2024


On 7/15/24 10:07, Frank Li wrote:
> Move post_rcs_wait into struct imx_wdt_hw_feature to simplify code logic
> for different compatible strings
> 
> i.MX93 and i.MX8ULP watchdog do not need to wait 2.5 clocks after RCS is
> done. Set post_rcs_wait to false explicitly to maintain code consistency.
> 
> Reviewed-by: Guenter Roeck <linux at roeck-us.net>
> Signed-off-by: Alice Guo <alice.guo at nxp.com>
> Reviewed-by: Ye Li <ye.li at nxp.com>
> Signed-off-by: Frank Li <Frank.Li at nxp.com>

Being more explicit here, to make sure this isn't picked up with my
Reviewed-by: tag:

NACK for the explicit and unnecessary additional initializations.

Guenter




More information about the linux-arm-kernel mailing list