[PATCH v6 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

[Andrew Lunn]

> +static int airoha_qdma_init_rx_queue(struct airoha_eth *eth,
> +				     struct airoha_queue *q, int ndesc)
> +{
> +	struct page_pool_params pp_params = {
> +		.order = 0,
> +		.pool_size = 256,
> +		.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV,
> +		.dma_dir = DMA_FROM_DEVICE,
> +		.max_len = PAGE_SIZE,
> +		.nid = NUMA_NO_NODE,
> +		.dev = eth->dev,
> +		.napi = &q->napi,
> +	};

I think you can make this const.

> +static int airoha_alloc_gdm_port(struct airoha_eth *eth, struct device_node *np)
> +{

> +	port = netdev_priv(dev);
> +	mutex_init(&port->stats.mutex);
> +	port->dev = dev;
> +	port->eth = eth;
> +	port->id = id;
> +
> +	err = register_netdev(dev);
> +	if (err)
> +		return err;
> +
> +	eth->ports[index] = port;

eth->ports[index] appears to be used in
airoha_qdma_rx_process(). There is a small race condition here, since
the interface could be in use before register_netdev() returns,
e.g. NFS root. It would be better to do the assignment before
registering the interface.

These are quite minor, so please add to the next version:

Reviewed-by: Andrew Lunn <andrew at lunn.ch>

    Andrew

---
pw-bot: cr