[PATCH v2 3/3] soc: ti: pm33xx: do device_node auto cleanup

Kousik Sanagavarapu five231003 at gmail.com
Fri Jul 5 04:11:20 PDT 2024


Hi Jonathan,

On Fri, Jul 05, 2024 at 11:54:13AM +0100, Jonathan Cameron wrote:
> On Wed,  3 Jul 2024 12:25:28 +0530
> Kousik Sanagavarapu <five231003 at gmail.com> wrote:
> 
> > Use scope based cleanup instead of manual of_node_put() calls, hence
> > simplifying the handling of error paths.
> > 
> > Suggested-by: Julia Lawall <julia.lawall at inria.fr>
> > Signed-off-by: Kousik Sanagavarapu <five231003 at gmail.com>
> I think you can make use of dev_err_probe() in here to
> further simplify things (a bit anyway!)

The changes proposed on all the patches make sense.  I'll send out v3
soon.

I hadn't caught the dev_err_probe() change in this patch ;) while
preparing this series.  I'll make the changes.

Thanks for the review



More information about the linux-arm-kernel mailing list