Duplicated bindings for mediatek,mt8173-scpsys

[AngeloGioacchino Del Regno]

Il 02/07/24 03:58, TingHan Shen (沈廷翰) ha scritto:
> On Fri, 2024-06-28 at 09:57 +0200, Rafał Miłecki wrote:
>> I noticed that "mediatek,mt8173-scpsys" compatible is specified in two
>> places:
>> Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
>> Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>>
>> The first one seems to be "real" hardware block. It also has a Linux
>> driver at drivers/pmdomain/mediatek/mtk-scpsys.c . It also seems that
>> scpsys.txt was first added explicitly for MT8173.
>>
>> The later one seems to be "just" an MFD with no real driver but it
>> seems to be actually used in arch/arm64/boot/dts/mediatek/mt8173.dtsi .
>>
>> Can I ask for some assistance sorting this out?
>>
>> Relevant kernel commits:
>>
>> commit 26331d261f49949bff6477fc9c844b17076fa245
>> Author: Tinghan Shen <tinghan.shen at mediatek.com>
>> Date:   Thu Aug 11 10:57:59 2022 +0800
>>
>>       dt-bindings: mfd: mt8195: Add bindings for MediaTek SCPSYS
>>
>> commit c84e358718a66f76ac0de1681d15d8d0c68fcdab
>> Author: Sascha Hauer <s.hauer at pengutronix.de>
>> Date:   Wed Jun 24 08:17:04 2015 +0200
>>
>>       soc: Mediatek: Add SCPSYS power domain driver
>>
>> commit 859e42800bcfc4db9cefaa2c24d6e3a203fe961d
>> Author: Sascha Hauer <s.hauer at pengutronix.de>
>> Date:   Wed Jun 24 08:17:03 2015 +0200
>>
>>       dt-bindings: soc: Add documentation for the MediaTek SCPSYS unit
> 
> Loop MTK members.
> 

Rafał, I suggest "out with the old, in with the new".

The old binding was referring to the mtk-scpsys power domain driver, which MT8173
has been migrated away from (years ago), as it now uses mtk-pm-domains instead.

I'd be happy if you could also actually remove the MT8173 support from the
mtk-scpsys.c driver too, as that has been, again, unused for more than 2 years now.

Honestly, I'd be even happier if we could even move MT27xx, 6797, 7622/23a from
mtk-scpsys to mtk-pm-domains, but I don't have any HW with any of these, I don't
expect you to have any either, so there's no way we can remove the old driver
entirely.

So....

Please go on and remove MT8173 from mtk-scpsys.c; you'll be able to resolve the
duplicated bindings accordingly to that change.

Cheers,
Angelo