[PATCH v2 02/12] perf: arm_pmuv3: Drop unnecessary IS_ENABLED(CONFIG_ARM64) check

Mark Rutland mark.rutland at arm.com
Mon Jul 1 10:11:21 PDT 2024


On Wed, Jun 26, 2024 at 04:32:26PM -0600, Rob Herring (Arm) wrote:
> The IS_ENABLED(CONFIG_ARM64) check for threshold support is unnecessary.
> The purpose is to not enable thresholds on arm32, but if threshold is
> non-zero, the check against threshold_max() just above here will have
> errored out because threshold_max() is always 0 on arm32.
> 
> Signed-off-by: Rob Herring (Arm) <robh at kernel.org>

Acked-by: Mark rutland <mark.rutland at arm.com>

Mark.

> ---
> v2:
>  - new patch
> ---
>  drivers/perf/arm_pmuv3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c
> index 8ed5c3358920..3e51cd7062b9 100644
> --- a/drivers/perf/arm_pmuv3.c
> +++ b/drivers/perf/arm_pmuv3.c
> @@ -1045,7 +1045,7 @@ static int armv8pmu_set_event_filter(struct hw_perf_event *event,
>  		return -EINVAL;
>  	}
>  
> -	if (IS_ENABLED(CONFIG_ARM64) && th) {
> +	if (th) {
>  		config_base |= FIELD_PREP(ARMV8_PMU_EVTYPE_TH, th);
>  		config_base |= FIELD_PREP(ARMV8_PMU_EVTYPE_TC,
>  					  armv8pmu_event_threshold_control(attr));
> 
> -- 
> 2.43.0
> 



More information about the linux-arm-kernel mailing list