[PATCH 3/3] ARM: dts: marvell: add support for D-Link DNS-320L

[Andrew Lunn]

> > I suspect that is not going to be easy to interpret. kirkwood is very
> > old, much older than the YAML descriptions. DT descriptions of this
> > age were considered correct if the kernel understood them, and the
> > kernel is much more flexible than the YAML bindings. As a result,
> > there are going to be a huge number of warnings, and it will take a
> > lot of skill to pick out real warning which can be fixed from the
> > noise. Also, nobody really cares, because these devices have been out
> > of production for a decade. Nobody is going to clean up the DT files.
> 
> One can just read the binding. Is there address/size cells?

And i suspect this developer also does not know that. This is a
typical cut/paste .dts file, copied from a 10 year old working
example. If the tools are not helpful, we Maintainers need to fill in
the gaps.

In this case, I would suggest looking in
arch/arm64/boot/dts/marvell/*.dts and follow what is done there. These
files are more modern, so are more likely to follow the bindings. Look
where the gpip-keys and gpip-led nodes are placed.

      Andrew