[PATCH] arm64/signal: Don't assume that TIF_SVE means we saved SVE state

Mark Brown broonie at kernel.org
Fri Jan 19 09:47:55 PST 2024


On Fri, Jan 19, 2024 at 04:31:13PM +0000, Dave Martin wrote:
> On Fri, Jan 19, 2024 at 12:29:13PM +0000, Mark Brown wrote:

> > When we are in a syscall we will only save the FPSIMD subset even though
> > the task still has access to the full register set, and on context switch

> (Pedantic nit: "A even if B" (= "A applies even in that subset of cases
> where B"), instead of "A even though B" (= "A applies notwithstanding
> that it is always the case that B") (?)  If the SVE trapping were
> ripped out altogether, it would be a different and rather simpler
> story...)

I really can't follow what you're trying to say here.  I'm not sure I
where the bit about "always" comes from here?

> If the historical meanings of TIF_SVE have been split up (which seems a
> good idea), does that resolve all of the "bare"
> test_thread_flag(TIF_SVE) that were still there?

There's a couple more, but this is all of them in the signal handling
code - I should have one or two more patches.  Most of the usage is
actually checking the trapping and therefore fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240119/5e8b35e5/attachment.sig>


More information about the linux-arm-kernel mailing list