[PATCH V16 1/8] arm64/sysreg: Add BRBE registers and fields

Mark Rutland mark.rutland at arm.com
Wed Feb 21 06:05:24 PST 2024


On Wed, Feb 21, 2024 at 01:59:03PM +0000, Mark Brown wrote:
> On Wed, Feb 21, 2024 at 01:52:38PM +0000, Mark Rutland wrote:
> > On Thu, Jan 25, 2024 at 03:11:12PM +0530, Anshuman Khandual wrote:
> 
> > Minor nit, but could we please list thse in order:
> 
> > 	BRBCR_EL1
> > 	BRBCR_EL12
> > 	BRBCR_EL2
> 
> > ... since that way the names are ordered alphnumerically, which is what we've
> > done for other groups (e.g. PIR_EL{1,12,2}), and it's the way the ARM ARM
> > happens to be ordered.
> 
> It's a good point about the sorting, though the file is currently mostly
> sorted by encoding rather than alphanumerically (similarly to how
> sysreg.h was done).

Sure, we're inconsistent. I'd just prefer that there's *some* local ordering
here, as the patch is neither ordered as above nor by encoding:

Sysreg       BRBCR_EL2       2       4       9       0       0
...
Sysreg       BRBCR_EL1       2       1       9       0       0
...
Sysreg       BRBCR_EL12      2       5       9       0       0

Mark.



More information about the linux-arm-kernel mailing list