[PATCH] drm/imx: Replace of_device.h with explicit includes

Umang Jain umang.jain at ideasonboard.com
Mon Feb 5 21:21:46 PST 2024


The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h.

of_device.h isn't needed, but of.h is for of_node_put().

This fixes the following build errors:
error: implicit declaration of function ‘platform_set_drvdata’ [-Werror=implicit-function-declaration]
error: implicit declaration of function ‘of_node_put’ [-Werror=implicit-function-declaration]

Fixes: 3075f087680b ("drm/imx: add driver for HDMI TX Parallel Video Interface")
Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
index 962779dc539e..8a51a2ac8df1 100644
--- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
+++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
@@ -8,9 +8,10 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/of_graph.h>
 #include <linux/pm_runtime.h>
+#include <linux/platform_device.h>
 
 #define HTX_PVI_CTL	0x0
 #define  PVI_CTL_OP_VSYNC_POL	BIT(18)
-- 
2.41.0




More information about the linux-arm-kernel mailing list