[PATCH] gpio: GPIO_MVEBU should not default to y when compile-testing

Andrew Lunn andrew at lunn.ch
Tue Dec 3 12:59:56 PST 2024


On Tue, Dec 03, 2024 at 09:29:02PM +0100, Bartosz Golaszewski wrote:
> On Tue, Dec 3, 2024 at 9:13 PM Andrew Lunn <andrew at lunn.ch> wrote:
> >
> > On Tue, Dec 03, 2024 at 05:23:16PM +0100, Geert Uytterhoeven wrote:
> > > Merely enabling compile-testing should not enable additional
> > > functionality.
> >
> > Sorry for being dumb, but i don't actually see what is wrong here.
> >
> > There are 4 GPIO drivers which have
> >
> >         def_bool y
> >
> > COMPILE_TEST is about building as much as possible, in order to find
> > build bugs. So i don't get what you mean by additional
> > functionality. No additional functionality within the MVEBU driver
> > gets enabled by COMPILE_TEST.
> >
> >         Andrew
> 
> No, Geert is right. I have been yelled at by Linus Torvalds already
> for too eagerly enabling too many options. COMPILE_TEST is really
> about making it possible to build more things with make allmodconfig,
> not necessarily defaulting to y for everything.

So are you saying COMPILE_TEST should allow something to be enabled,
but should not actually enable it?

	Andrew



More information about the linux-arm-kernel mailing list