[PATCH 07/15] i2c: st: use 'time_left' variable with wait_for_completion_timeout()
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Sun Apr 28 05:15:11 PDT 2024
Hello Wolfram,
On Sat, Apr 27, 2024 at 10:35:59PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
>
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
I like the improvement in general and looking at this driver in more
detail this looks right.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240428/18641b49/attachment.sig>
More information about the linux-arm-kernel
mailing list