[PATCH v3 4/4] media: mediatek: imgsys: Support image processing

[AngeloGioacchino Del Regno]

Il 24/04/24 12:02, AngeloGioacchino Del Regno ha scritto:
> Il 24/04/24 05:03, Olivia Wen ha scritto:
>> Integrate the imgsys core architecture driver for image processing on
>> the MT8188 platform.
>>
>> Signed-off-by: Olivia Wen <olivia.wen at mediatek.com>
> 
> This should be reordered before introducing the 8188 scp core 1 support commit,
> but let's check with Mathieu before sending a v4.
> 
> With that reordered,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>

Wait, no. Sorry. I just noticed that the commit message is totally wrong.

This is not a media commit, but remoteproc, and you're not adding support for
image processing with this commit - not in media at least.
Also, you're not adding any imgsys core architecture driver.

Please fix both commit description and title.

Regards,
Angelo

> 
>> ---
>>   include/linux/remoteproc/mtk_scp.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/remoteproc/mtk_scp.h b/include/linux/remoteproc/mtk_scp.h
>> index 7c2b7cc9..344ff41 100644
>> --- a/include/linux/remoteproc/mtk_scp.h
>> +++ b/include/linux/remoteproc/mtk_scp.h
>> @@ -43,6 +43,7 @@ enum scp_ipi_id {
>>       SCP_IPI_CROS_HOST_CMD,
>>       SCP_IPI_VDEC_LAT,
>>       SCP_IPI_VDEC_CORE,
>> +    SCP_IPI_IMGSYS_CMD,
>>       SCP_IPI_NS_SERVICE = 0xFF,
>>       SCP_IPI_MAX = 0x100,
>>   };
>