[PATCH 1/2] pwm: meson: drop unneeded check in get_state callback
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Wed Apr 24 00:19:34 PDT 2024
Hello George,
On Tue, Apr 23, 2024 at 07:13:55PM +0300, George Stark wrote:
> Drop checking state argument for null pointer in meson_pwm_get_state()
> due to it is called only from pwm core with always valid arguments.
>
> Fixes: 211ed630753d ("pwm: Add support for Meson PWM Controller")
> Signed-off-by: George Stark <gnstark at salutedevices.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov at salutedevices.com>
I'd apply this one with the following changes if you agree:
- capitalize "drop" in the Subject line
- s/get_state/.get_state()/
- make "null" all caps (i.e. "NULL")
- swap the order of Signed-off-by lines to have yours last.
Alternatively send it in a v2 together with addressing the comment in
the second patch.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240424/a89b9ffb/attachment.sig>
More information about the linux-arm-kernel
mailing list