[PATCH] Avoid error message on rk3328 use
Etienne Buira
etienne.buira at free.fr
Sat Apr 13 06:56:08 PDT 2024
rockchip,rk3328-grf-gpio is handled as syscon, but syscon mandates
presence of gpio,syscon-dev node (or it will call dev_err() when probed).
Correct rk3328.dtsi and related documentation to follow syscon's
expectations.
Signed-off-by: Etienne Buira <etienne.buira at free.fr>
---
.../devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml | 2 ++
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml
index d8cce73ea0ae..2c878e7db900 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml
@@ -38,6 +38,7 @@ required:
- compatible
- gpio-controller
- "#gpio-cells"
+ - gpio,syscon-dev
additionalProperties: false
@@ -47,4 +48,5 @@ examples:
compatible = "rockchip,rk3328-grf-gpio";
gpio-controller;
#gpio-cells = <2>;
+ gpio,syscon-dev = <&grf 0 0>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index b6f045069ee2..fd25d5bee19f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -296,6 +296,7 @@ grf_gpio: gpio {
compatible = "rockchip,rk3328-grf-gpio";
gpio-controller;
#gpio-cells = <2>;
+ gpio,syscon-dev = <&grf 0 0>;
};
power: power-controller {
base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23
--
2.43.0
More information about the linux-arm-kernel
mailing list