[PATCH v2 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C mux node name with bindings

[Krzysztof Kozlowski]

On 11/04/2024 20:27, Rob Herring wrote:
>>  };
>>
>>  &axi {
>> -       i2c0_imux: i2c0-imux at 0 {
>> +       i2c0_imux: i2c-mux-0 {
> 
> Doesn't this introduce a new warning with simple-bus.yaml? These
> devices shouldn't be under an AXI bus which should require a
> unit-address.
> 
> All the sft-eth* nodes have the same problem:
> axi at 600000000: sfp-eth63: {'compatible': ['sff,sfp'], 'i2c-bus':
> [[91]], 'tx-disable-gpios': [[87, 31, 0, 1]], 'rate-select0-gpios':
> [[87, 31, 1, 0]], 'los-gpios': [[88, 31, 0, 0]], 'mod-def0-gpios':
> [[88, 31, 1, 1]], 'tx-fault-gpios': [[88, 31, 2, 0]], 'phandle':
> [[78]]} should not be valid under {'type': 'object'}
> 

True, this replaces one dtc warning with another, so the new one is:
Warning (simple_bus_reg): /axi at 600000000/i2c-mux: missing or empty
reg/ranges property

which I kind of missed, because there are several other sfp nodes
causing the warning, like you mentioned above.

The true solution is to probably bring them out of axi bus, but for that
I would need to try to understand why they were put there in the first
place...


Best regards,
Krzysztof