[PATCH v2 2/3] firmware: raspberrypi: Use correct device for DMA mappings

Florian Fainelli florian.fainelli at broadcom.com
Thu Apr 4 09:46:53 PDT 2024


From: Florian Fainelli <f.fainelli at gmail.com>

On Tue, 26 Mar 2024 21:58:06 +0200, Laurent Pinchart <laurent.pinchart at ideasonboard.com> wrote:
> The buffer used to transfer data over the mailbox interface is mapped
> using the client's device. This is incorrect, as the device performing
> the DMA transfer is the mailbox itself. Fix it by using the mailbox
> controller device instead.
> 
> This requires including the mailbox_controller.h header to dereference
> the mbox_chan and mbox_controller structures. The header is not meant to
> be included by clients. This could be fixed by extending the client API
> with a function to access the controller's device.
> 
> Fixes: 4e3d60656a72 ("ARM: bcm2835: Add the Raspberry Pi firmware driver")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian



More information about the linux-arm-kernel mailing list