[PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC

Andrew Jeffery andrew at codeconstruct.com.au
Tue Apr 2 20:29:17 PDT 2024


Hi Renze,

On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote:
> This commit disables unused ADC channels and labels the ADC channels used with their function.

Please run this through checkpatch and address the warnings.

Also, the submitting patches documentation[1] suggests using the
imperative mood - instead of "This commit disables ...", use "Disable
...". The change subject is phrased the expected way.

[1]: https://docs.kernel.org/process/submitting-patches.html

Taking the subject and the description together, the description feels
a little redundant. Maybe it could be trimmed back to

> Also, label the ADC channels used with their function.

Andrew




More information about the linux-arm-kernel mailing list