[PATCH v5 3/4] dt-bindings: clock: add i.MX95 clock header
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Mon Apr 1 02:51:41 PDT 2024
On 01/04/2024 09:26, Peng Fan wrote:
>> Subject: Re: [PATCH v5 3/4] dt-bindings: clock: add i.MX95 clock header
>>
>> On 24/03/2024 08:52, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan at nxp.com>
>>>
>>> Add clock header for i.MX95 BLK CTL modules
>>>
>>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>>> ---
>>> include/dt-bindings/clock/nxp,imx95-clock.h | 32
>> +++++++++++++++++++++++++++++
>>> 1 file changed, 32 insertions(+)
>>>
>>> diff --git a/include/dt-bindings/clock/nxp,imx95-clock.h b/include/dt-
>> bindings/clock/nxp,imx95-clock.h
>>> new file mode 100644
>>> index 000000000000..83fa3ffe78a8
>>> --- /dev/null
>>> +++ b/include/dt-bindings/clock/nxp,imx95-clock.h
>>> @@ -0,0 +1,32 @@
>>> +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */
>>> +/*
>>> + * Copyright 2024 NXP
>>> + */
>>> +
>>> +#ifndef __DT_BINDINGS_CLOCK_IMX95_H
>>> +#define __DT_BINDINGS_CLOCK_IMX95_H
>>> +
>>> +#define IMX95_CLK_VPUBLK_WAVE 0
>>> +#define IMX95_CLK_VPUBLK_JPEG_ENC 1
>>> +#define IMX95_CLK_VPUBLK_JPEG_DEC 2
>>> +#define IMX95_CLK_VPUBLK_END 3
>>
>> No improvements, so again: drop counting.
>
> Could you please give more details on what you think needs
> to be addressed here? I may overlook your comments before,
> but I search v1-v4, not find comments on the headers,
> except the one file name align with binding if 1:1 match.
Drop all defines which count number of clocks.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list