[PATCH v4 1/5] lib/bitmap: add bitmap_{set,get}_value()
Alexander Potapenko
glider at google.com
Fri Sep 22 00:48:41 PDT 2023
> Either way, whatever we decide, let's stay clear with our intentions
> and mention explicitly that tail bits are either must be zero, or
> ignored.
>
> Alexander, can you add the snippet above to the comments for the
> bitmap_write() and bitmap_read(), as well as in the test? Also, if we
> decide to clear tail of the input value, would BITMAP_LAST_WORD_MASK()
> generate better code than GENMASK(nbits - 1, 0) does?
Added the snippet above to bitmap_write(). I think however it is
obvious that bitmap_read() reads only nbits?
> Commets are very appreciated.
>
> Thanks,
> Yury
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
More information about the linux-arm-kernel
mailing list