[PATCH] firmware: arm_scmi:: Add opinion for init fastchannel

Sudeep Holla sudeep.holla at arm.com
Tue Oct 31 02:27:48 PDT 2023


On Tue, Oct 31, 2023 at 09:36:01AM +0800, xinglong.yang wrote:
> Fastchannel may not be supported by the platform. It is not need to
> init the fastchannel if the fastchannel is not supported.
> 
> Signed-off-by: xinglong.yang <xinglong.yang at cixtech.com>
> Change-Id: Id73ab1f37d5a3726243f97beb40c5b2239d65727
> ---
>  drivers/firmware/arm_scmi/perf.c | 38 ++++++++++++++++++--------------
>  1 file changed, 21 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index ecf5c4de851b..26fa71e2aff8 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -835,7 +839,7 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
>  		scmi_perf_describe_levels_get(ph, domain, dom);
> 
>  		if (dom->perf_fastchannels)

If the platform doesn't support fast channels, this must not be set and
any change must not take any effect on your platform. Why are you changing
this then ?

> -			scmi_perf_domain_init_fc(ph, domain, &dom->fc_info);
> +			scmi_perf_domain_init_fc(ph, domain, dom);
>  	}
>
--
Regards,
Sudeep



More information about the linux-arm-kernel mailing list