[PATCH v1] coresight-tpdm: Correct the property name of MSR number
Suzuki K Poulose
suzuki.poulose at arm.com
Wed Oct 25 03:27:08 PDT 2023
Hi
Please always run a checkpatch on your patch before submission.
(And of course test your patch properly for all the functionality
that it introduces. We don't have the hardware for testing all of
this. So, there is only so much we could do with the eyes)
On 24/10/2023 07:19, Tao Zhang wrote:
> Correct the property name of the DSB MSR number that needs to be
> read in TPDM driver. The right property name is
> "qcom,dsb-msrs-num".
>
> Fixes: 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")
> Signed-off-by: Tao Zhang <quic_taozha at quicinc.com>
> ---
> drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
> index b25284e..97654aa 100644
> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> @@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id)
>
> if (drvdata && tpdm_has_dsb_dataset(drvdata))
> of_property_read_u32(drvdata->dev->of_node,
> - "qcom,dsb_msr_num", &drvdata->dsb_msr_num);
> + "qcom,dsb-msrs-num", &drvdata->dsb_msr_num);
>
> /* Set up coresight component description */
> desc.name = coresight_alloc_device_name(&tpdm_devs, dev);
checkpatch complains:
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 90a7371cb08d ("coresight-tpdm: Add
nodes for dsb msr support")'
#13:
Fixes: 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")
total: 1 errors, 0 warnings, 8 lines checked
Suzuki
More information about the linux-arm-kernel
mailing list