[PATCH 2/3] perf/arm-cmn: Rework DTC counters (again)
Ilkka Koskinen
ilkka at os.amperecomputing.com
Tue Oct 24 20:18:59 PDT 2023
On Mon, 23 Oct 2023, Mark Rutland wrote:
> On Fri, Oct 20, 2023 at 03:50:30PM -0700, Ilkka Koskinen wrote:
>> Hi Robin,
>>
>> I have one comment, otherwise the patch looks good to me.
>
>>> +/* @i is the DTC number, @idx is the counter index on that DTC */
>>> +#define for_each_hw_dtc_idx(hw, i, idx) \
>>> + for (int i = 0, idx; i < CMN_MAX_DTCS; i++) if ((idx = hw->dtc_idx[i]) >= 0)
>>
>> Isn't that "idx" unnecessary in the initialization?
>
> That creates the 'idx' variable that's assigned to by `idx = hw->dtc_idx[i]`,
> so that is necessary.
Uh, it clearly does that. I have absoutely no idea what I was thinking
about here. Sorry about the confusion!
--Ilkka
>
> Mark.
>
More information about the linux-arm-kernel
mailing list