[PATCH] spi: stm32: Explicitly include correct DT includes

Alain Volmat alain.volmat at foss.st.com
Tue Oct 10 01:01:38 PDT 2023


Hi Rob,

thanks for the patch.

Acked-by: Alain Volmat <alain.volmat at foss.st.com>

Regards,
Alain

On Mon, Oct 09, 2023 at 04:13:44PM -0500, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
>  drivers/spi/spi-stm32.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index ef665f470c5b..e6e3e4ea29f9 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -13,7 +13,8 @@
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
>  #include <linux/module.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/reset.h>
> -- 
> 2.42.0
> 



More information about the linux-arm-kernel mailing list