[PATCH 37/37] arm64: Remove cpus_have_const_cap()

Mark Rutland mark.rutland at arm.com
Thu Oct 5 02:35:32 PDT 2023


On Tue, Oct 03, 2023 at 06:20:25PM +0100, Kristina Martsenko wrote:
> On 19/09/2023 10:28, Mark Rutland wrote:
> > There are no longer any users of cpus_have_const_cap(), and therefore it
> > can be removed.
> > 
> > Remove cpus_have_const_cap(). At the same time, remove
> > __cpus_have_const_cap(), as this is a trivial wrapper of
> > alternative_has_cap_unlikely(), which can be used directly instead.
> 
> Nit: The comment above __system_matches_cap() still mentions
> cpus_have_const_cap():
> 
> /*
>  * This helper function is used in a narrow window when,
>  * - The system wide safe registers are set with all the SMP CPUs and,
>  * - The SYSTEM_FEATURE system_cpucaps may not have been set.
>  * In all other cases cpus_have_{const_}cap() should be used.
>  */

Thanks! I missed that when grepping for cpus_have_const_cap().

Given we have a number of ways to check the cpucaps, I've deleted the last line
in its entirety.

Mark.



More information about the linux-arm-kernel mailing list