[net-next PATCH 1/3] net: introduce napi_is_scheduled helper

Eric Dumazet edumazet at google.com
Mon Oct 2 05:35:22 PDT 2023


On Mon, Oct 2, 2023 at 2:29 PM Christian Marangi <ansuelsmth at gmail.com> wrote:

> Ehhh the idea here was to reduce code duplication since the very same
> test will be done in stmmac. So I guess this code cleanup is a NACK and
> I have to duplicate the test in the stmmac driver.

I simply wanted to add a comment in front of this function/helper,
advising not using it unless absolutely needed.

Thus my question "In which context is it safe to call this helper ?"

As long as it was private with a driver, I did not mind.

But if made public in include/linux/netdevice.h, I would rather not
have to explain
to future users why it can be problematic.



More information about the linux-arm-kernel mailing list