[PATCH 03/21] x86/topology: remove arch_*register_cpu() exports

Jonathan Cameron Jonathan.Cameron at Huawei.com
Thu Nov 30 08:48:19 PST 2023


On Tue, 21 Nov 2023 13:44:05 +0000
"Russell King (Oracle)" <rmk+kernel at armlinux.org.uk> wrote:

> arch_register_cpu() and arch_unregister_cpu() are not used by anything
> that can be a module - they are used by drivers/base/cpu.c and
> drivers/acpi/acpi_processor.c, neither of which can be a module.
> 
> Remove the exports.
> 
> Reviewed-by: Gavin Shan <gshan at redhat.com>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
I somehow ended up replying to the RFC even though you'd posted this.
On basis this might get picked up directly from this posting.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>

> ---
>  arch/x86/kernel/topology.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
> index 0bab03130033..fcb62cfdf946 100644
> --- a/arch/x86/kernel/topology.c
> +++ b/arch/x86/kernel/topology.c
> @@ -45,13 +45,11 @@ int arch_register_cpu(int cpu)
>  	xc->cpu.hotpluggable = cpu > 0;
>  	return register_cpu(&xc->cpu, cpu);
>  }
> -EXPORT_SYMBOL(arch_register_cpu);
>  
>  void arch_unregister_cpu(int num)
>  {
>  	unregister_cpu(&per_cpu(cpu_devices, num).cpu);
>  }
> -EXPORT_SYMBOL(arch_unregister_cpu);
>  #else /* CONFIG_HOTPLUG_CPU */
>  
>  int __init arch_register_cpu(int num)




More information about the linux-arm-kernel mailing list