[PATCH 2/5] dt-bindings: arm: qcom: Document SC8380XP SoC and boards

Sibi Sankar quic_sibis at quicinc.com
Thu Nov 16 20:07:18 PST 2023


Hey Krzysztof,

Thanks for taking time to review the series.

On 10/27/23 13:46, Krzysztof Kozlowski wrote:
> On 25/10/2023 16:24, Sibi Sankar wrote:
>> From: Rajendra Nayak <quic_rjendra at quicinc.com>
>>
>> Document the SC8380XP SoC binding and also the boards using it.
>> Also document the new board id qcp (Qualcomm Compute Platform).
>>
>> Signed-off-by: Rajendra Nayak <quic_rjendra at quicinc.com>
>> Signed-off-by: Sibi Sankar <quic_sibis at quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 88b84035e7b1..6145e9ad340c 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -62,6 +62,7 @@ description: |
>>           sc7280
>>           sc8180x
>>           sc8280xp
>> +        sc8380xp
>>           sda660
>>           sdm450
>>           sdm630
>> @@ -110,6 +111,7 @@ description: |
>>           liquid
>>           rdp432-c2
>>           mtp
>> +        qcp
>>           qrd
>>           rb2
>>           ride
>> @@ -1044,6 +1046,12 @@ properties:
>>                 - qcom,sm8550-qrd
>>             - const: qcom,sm8550
>>   
>> +      - items:
>> +          - enum:
>> +              - qcom,sc8380xp-crd
>> +              - qcom,sc8380xp-qcp
>> +          - const: qcom,sc8380xp
> 
> This is some odd placement. Please keep things properly ordered.

will fix this in the next re-spin.

-Sibi

> 
> Best regards,
> Krzysztof
> 



More information about the linux-arm-kernel mailing list