[PATCH v2 01/19] iommu/arm-smmu-v3: Add a type for the STE

[Jason Gunthorpe]

On Wed, Nov 15, 2023 at 07:52:17PM +0800, Michael Shavit wrote:

> > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > > index 961205ba86d25d..03f9e526cbd92f 100644
> > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > > @@ -206,6 +206,11 @@
> > >  #define STRTAB_L1_DESC_L2PTR_MASK    GENMASK_ULL(51, 6)
> > >
> > >  #define STRTAB_STE_DWORDS            8
> > > +
> > > +struct arm_smmu_ste {
> > > +     __le64 data[STRTAB_STE_DWORDS];
> > > +};
> > > +
> 
> nit: This looks out of place at this location compared to the rest of
> the file. All of the other structs are defined after this large block
> of #defines.

The struct follows the defines that specify how to parse its content,
which is pretty normal

Thanks,
Jason