[PATCH 52/52] serial: xilinx_uartps: Convert to platform remove callback returning void

[Uwe Kleine-König]

On Mon, Nov 13, 2023 at 10:41:17AM +0100, Michal Simek wrote:
> 
> 
> On 11/10/23 16:30, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> > 
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> > 
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > ---
> >   drivers/tty/serial/xilinx_uartps.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> > index 66a45a634158..6decf2b13340 100644
> > --- a/drivers/tty/serial/xilinx_uartps.c
> > +++ b/drivers/tty/serial/xilinx_uartps.c
> > @@ -1666,7 +1666,7 @@ static int cdns_uart_probe(struct platform_device *pdev)
> >    *
> >    * Return: 0 on success, negative errno otherwise
> 
> this line should be also removed.

Good catch.

@gregkh: What is the preferred way to address that? I can follow up with
a patch on top of this one (and you squash it or not), I can send a
patch that gets that does the conversion and drops the comment (and you
skip this incomplete patch when applying this series) or I can resend
the whole series in a week or so.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20231113/7a703f2e/attachment.sig>