[PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC

Alim Akhtar alim.akhtar at samsung.com
Thu Nov 9 10:05:54 PST 2023



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Wednesday, November 8, 2023 4:13 PM
> To: David Airlie <airlied at gmail.com>; Daniel Vetter <daniel at ffwll.ch>;
> Maarten Lankhorst <maarten.lankhorst at linux.intel.com>; Maxime Ripard
> <mripard at kernel.org>; Thomas Zimmermann <tzimmermann at suse.de>;
> Rob Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt at linaro.org>; Conor Dooley
> <conor+dt at kernel.org>; Alim Akhtar <alim.akhtar at samsung.com>; Andi
> Shyti <andi.shyti at kernel.org>; Jonathan Cameron <jic23 at kernel.org>; Lars-
> Peter Clausen <lars at metafoo.de>; Lee Jones <lee at kernel.org>; Ulf
> Hansson <ulf.hansson at linaro.org>; Tomasz Figa <tomasz.figa at gmail.com>;
> Sylwester Nawrocki <s.nawrocki at samsung.com>; Linus Walleij
> <linus.walleij at linaro.org>; Thierry Reding <thierry.reding at gmail.com>; Uwe
> Kleine-König <u.kleine-koenig at pengutronix.de>; Alessandro Zummo
> <a.zummo at towertech.it>; Alexandre Belloni
> <alexandre.belloni at bootlin.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>; Jiri Slaby <jirislaby at kernel.org>; Liam
> Girdwood <lgirdwood at gmail.com>; Mark Brown <broonie at kernel.org>;
> Jaehoon Chung <jh80.chung at samsung.com>; Sam Protsenko
> <semen.protsenko at linaro.org>; dri-devel at lists.freedesktop.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; linux-samsung-soc at vger.kernel.org; linux-
> i2c at vger.kernel.org; linux-iio at vger.kernel.org; linux-mmc at vger.kernel.org;
> linux-gpio at vger.kernel.org; linux-pwm at vger.kernel.org; linux-
> rtc at vger.kernel.org; linux-serial at vger.kernel.org; alsa-devel at alsa-
> project.org; linux-sound at vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Subject: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for
> existing SoC
> 
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only.  This works fine and
> there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
> 
> Add compatibles specific to each SoC in front of all old-SoC-like compatibles.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> 
> ---
> 
> I propose to take the patch through Samsung SoC (me). See cover letter for
> explanation.
> ---
>  Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++-
>  .../devicetree/bindings/soc/samsung/exynos-usi.yaml    |  2 +-
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> index 3e52a0db6c41..c1f5d2cb7709 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml
> @@ -25,7 +25,15 @@ properties:
>            - samsung,exynos5250-hsi2c    # Exynos5250 and Exynos5420
>            - samsung,exynos5260-hsi2c    # Exynos5260
>            - samsung,exynos7-hsi2c       # Exynos7
> -          - samsung,exynosautov9-hsi2c  # ExynosAutoV9 and Exynos850
> +          - samsung,exynosautov9-hsi2c
> +      - items:
> +          - enum:
> +              - samsung,exynos5433-hsi2c
> +          - const: samsung,exynos7-hsi2c
> +      - items:
> +          - enum:
> +              - samsung,exynos850-hsi2c
Does this need an entry in allOf:? to indicate exynos850 also has 2 clocks?

> +          - const: samsung,exynosautov9-hsi2c
>        - const: samsung,exynos5-hsi2c    # Exynos5250 and Exynos5420
>          deprecated: true
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-
> usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-
> usi.yaml
> index a6836904a4f8..5b7ab69546c4 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -155,7 +155,7 @@ examples:
>          };
> 
>          hsi2c_0: i2c at 13820000 {
> -            compatible = "samsung,exynosautov9-hsi2c";
> +            compatible = "samsung,exynos850-hsi2c",
> + "samsung,exynosautov9-hsi2c";
>              reg = <0x13820000 0xc0>;
>              interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
>              #address-cells = <1>;
> --
> 2.34.1






More information about the linux-arm-kernel mailing list