[PATCH v3 1/3] arm64: dts: Add device tree for the Emtop SOM IMX8MM

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed May 10 05:58:36 PDT 2023


On 10/05/2023 10:32, Himanshu Bhavani wrote:
> Add a device tree file describing the Emtop SOM IMX8MM
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani at siliconsignals.io>
> ---

(...)

> +
> +	pinctrl_i2c1: i2c1grp {
> +		fsl,pins = <
> +			MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL				0x400001c3
> +			MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA				0x400001c3
> +		>;
> +	};
> +
> +	pinctrl_pmic: pmicirq {

grp suffix

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list