[PATCH v3 34/62] mmc: meson-mx-sdio: Convert to platform remove callback returning void

Martin Blumenstingl martin.blumenstingl at googlemail.com
Sat Jul 29 12:02:12 PDT 2023


On Thu, Jul 27, 2023 at 9:02 AM Yangtao Li <frank.li at vivo.com> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li at vivo.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>



More information about the linux-arm-kernel mailing list