[PATCH v1 2/7] iommu/arm-smmu-v3: Replace s1_cfg with ctx_desc_cfg
Jason Gunthorpe
jgg at nvidia.com
Fri Jul 28 05:22:52 PDT 2023
On Fri, Jul 28, 2023 at 03:47:45PM +0800, Michael Shavit wrote:
> On Fri, Jul 28, 2023 at 4:57 AM Nicolin Chen <nicolinc at nvidia.com> wrote:
>
> > It'd be nicer to align all the variables to "cd_table" like the
> > 2nd piece here. And if we rename the struct name too:
> >
> > struct arm_smmu_cdtab_cfg *cd_table = xxxx;
>
> I agree that renaming these would be nice. There's 36 usages of cdcfg
> in arm-smmu-v3.c, and 6 usages of arm_smmu_ctx_desc_cfg.
> I can rename the struct since we'll be touching many of those in this
> patch anyways, but I'm a bit concerned of the churn from updating all
> the cdcfg usages.
Will was not keen on churn for clarity so it seem better to be
thoughtful about what is touched to get this merged.
Jason
More information about the linux-arm-kernel
mailing list