[PATCH -next v2] power: supply: Remove redundant dev_err_probe() for platform_get_irq_byname()

[Dhruva Gole]

On Jul 27, 2023 at 19:35:50 +0800, Ruan Jinjie wrote:
> There is no need to call the dev_err_probe() function directly to print
> a custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message
> in case of a failure.

Ah yes, good catch!

> 
> Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> ---
> v2:
> - clarify the commit title
> ---
>  drivers/power/supply/mt6370-charger.c       | 4 +---
>  drivers/power/supply/qcom_pmi8998_charger.c | 3 +--
>  2 files changed, 2 insertions(+), 5 deletions(-)

Reviewed-by: Dhruva Gole <d-gole at ti.com>

> 
> diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
> index f27dae5043f5..571cf00dde07 100644
> --- a/drivers/power/supply/mt6370-charger.c
> +++ b/drivers/power/supply/mt6370-charger.c
> @@ -849,9 +849,7 @@ static int mt6370_chg_init_irq(struct mt6370_priv *priv)
>  		ret = platform_get_irq_byname(to_platform_device(priv->dev),
>  					      mt6370_chg_irqs[i].name);
>  		if (ret < 0)
> -			return dev_err_probe(priv->dev, ret,
> -					     "Failed to get irq %s\n",
> -					     mt6370_chg_irqs[i].name);
> +			return ret;
>  
>  		priv->irq_nums[i] = ret;
>  		ret = devm_request_threaded_irq(priv->dev, ret, NULL,
> diff --git a/drivers/power/supply/qcom_pmi8998_charger.c b/drivers/power/supply/qcom_pmi8998_charger.c
> index d16c5ee17249..ce7392e7d8b8 100644
> --- a/drivers/power/supply/qcom_pmi8998_charger.c
> +++ b/drivers/power/supply/qcom_pmi8998_charger.c
> @@ -922,8 +922,7 @@ static int smb2_init_irq(struct smb2_chip *chip, int *irq, const char *name,
>  
>  	irqnum = platform_get_irq_byname(to_platform_device(chip->dev), name);
>  	if (irqnum < 0)
> -		return dev_err_probe(chip->dev, irqnum,
> -				     "Couldn't get irq %s byname\n", name);
> +		return irqnum;
>  
>  	rc = devm_request_threaded_irq(chip->dev, irqnum, NULL, handler,
>  				       IRQF_ONESHOT, name, chip);
> -- 
> 2.34.1
> 

-- 
Best regards,
Dhruva Gole <d-gole at ti.com>